samples: boards: nrf: nrfx_prs: extend regex to test default task #72686
Conversation
Verifies that at least SPIM is initialized properly. Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
zephyrbot
requested review from
anangl,
jaz1-nordic,
kartben,
kl-cruz,
magp-nordic,
masz-nordic,
nashif and
nika-nordic
There was a problem hiding this comment.
I don't think this test is validating PRS properly.
First, the regex does not verify TX==RX.
Second, to fully test this functionality you would need to switch back and forth between SPIM and UARTE.
Checking if SPIM has initialized properly does not give much value and may lead to an invalid assumption that PRS is covered in verification.
| - "Switched to SPIM" | ||
| - "-- Background transfer on \".*\" --" | ||
| - "Tx: 4E 6F 72 64 69 63 20 53 65 6D 69 63 6F 6E 64 75 63 74 6F 72 00" | ||
| - "Rx:" |
There was a problem hiding this comment.
I would expect RX to be equal to TX?
There was a problem hiding this comment.
Only if you have loopback connected. This seems to be optional for this sample. So I did not wanted to enforce that.
I agree. However that require more effort to extend this test. |
carlescufi
added
the
Trivial
Verifies that at least SPIM is initialized properly.