Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: zperf: Fix upload ping timeout error #72692

Merged
merged 1 commit into from
May 15, 2024

Conversation

Ayush1325
Copy link
Member

@Ayush1325 Ayush1325 commented May 13, 2024

Fixes remote address for ping before upload. This caused the ping in zperf
upload to timeout as shown in the following output:

uart:~$ zperf udp upload 2001:db8::2 5001 10 50 1M
Remote port is 5001
Connecting to 2001:db8::2
Duration:       10.00 s
Packet size:    50 bytes
Rate:           1000 kbps
Starting...
ping 2001:db8::2 timeout
Rate:           1.00 Mbps
Packet duration 390 us

Fixes: #68674

Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please update the commit subject, the "Fix ping" is too short and does not tell enough, not sure what to put here
  • The commit message needs more information, it does not really tell "why" this fix is needed.

@Ayush1325 Ayush1325 changed the title subsys: net: zperf: Fix ping net: zperf: Fix ping timeout before upload May 13, 2024
Fixes remote address for ping before upload. This caused the ping in zperf
upload to timeout as shown in the following output:

```
uart:~$ zperf udp upload 2001:db8::2 5001 10 50 1M
Remote port is 5001
Connecting to 2001:db8::2
Duration:       10.00 s
Packet size:    50 bytes
Rate:           1000 kbps
Starting...
ping 2001:db8::2 timeout
Rate:           1.00 Mbps
Packet duration 390 us
```

Fixes: zephyrproject-rtos#68674

Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
@Ayush1325 Ayush1325 changed the title net: zperf: Fix ping timeout before upload net: zperf: Fix upload ping timeout error May 13, 2024
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@carlescufi carlescufi merged commit 56882e2 into zephyrproject-rtos:main May 15, 2024
23 checks passed
@Ayush1325 Ayush1325 deleted the zperf-ping-fix branch May 15, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zperf ping timeout on beagleconnect_freedom over subg
5 participants