boards: st: remove "- sdhc" tag from supported list #72695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDHC twister tag indicates that the board supports an SD host controller driver. Since the ST SDMMC support is provided directly via a disk driver, SDHC tests are not supported on ST boards. Drop this tag in order to avoid twister failures running the SDHC tests on these platforms. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
STM32 devices with an SDMMC driver will still need to be tested, but they do not use the SDHC framework for their disk driver. Therefore, add a special testcase to validate disk access support for devices with the STM32 specific SDMMC DT compatible enabled. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
zephyrbot
requested review from
ajarmouni-st,
decsny,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV and
jfischer-no
erwango
approved these changes
May 13, 2024
There was a problem hiding this comment.
Looks fine to me, thanks @danieldegrasse for theses changes!
ajarmouni-st
approved these changes
May 13, 2024
decsny
approved these changes
May 13, 2024
dleach02
approved these changes
May 13, 2024
|
Reassigning to @decsny, I can't review my own PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDHC twister tag indicates that the board supports an SD host controller
driver. Since the ST SDMMC support is provided directly via a disk
driver, SDHC tests are not supported on ST boards. Drop this tag in
order to avoid twister failures running the SDHC tests on these
platforms.
In order to ensure these boards still receive testing, add an STM32 specific testcase for disk access to the
tests/drivers/disk/disk_accesstestcase.yaml