soc: espressif: refactor clock and RTC subsystems #72701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Xtensa
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
requested review from
andyross,
carlocaione,
decsny,
edersondisouza,
fkokosinski,
galak,
katsuster,
kgugala,
marekmatej,
mgielda,
nordic-krch,
teburd and
tgorochowik
decsny
previously requested changes
May 13, 2024
LucasTambor
force-pushed
the
esp32/rtc_refactor
branch
from
6e8d85c
to
caf880e
Compare
@decsny there is no need indeed for this default values, it can depend mostly on the application and power requirements. I removed the default values and added |
LucasTambor
force-pushed
the
esp32/rtc_refactor
branch
from
caf880e
to
727ce09
Compare
LucasTambor
force-pushed
the
esp32/rtc_refactor
branch
from
727ce09
to
b0a825d
Compare
LucasTambor
force-pushed
the
esp32/rtc_refactor
branch
from
b0a825d
to
5be9e43
Compare
Add changes to comply with rtc refactor. Signed-off-by: Lucas Tamborrino <lucas.tamborrino@espressif.com>
The RTC subsystem in espressif's SOCs, among other tasks is responsible for clock selection for CPU and for low power domain clocks such as RTC_SLOW and RTC_FAST. This commit allows for proper clock source and rate selection for CPU, using the espressif,riscv and espressif,xtensa-lx6/7 bindings. It also enables clock selection for RTC_FAST and RTC_SLOW, that impacts some peripherals, such as rtc_timer. Signed-off-by: Lucas Tamborrino <lucas.tamborrino@espressif.com>
Changes for making the clock control api tests generic for any board. All the device subsys definitions were moved to its own folder according to the clock compatible. Also if the clock's async feature is not supported by the target, the test is skipped instead of failed. Signed-off-by: Lucas Tamborrino <lucas.tamborrino@espressif.com>
Add support for rtc timer node in the test. Signed-off-by: Lucas Tamborrino <lucas.tamborrino@espressif.com>
Add tests for the rtc clk subsystem. Signed-off-by: Lucas Tamborrino <lucas.tamborrino@espressif.com>
LucasTambor
force-pushed
the
esp32/rtc_refactor
branch
from
5be9e43
to
9bf47c3
Compare
sylvioalves
approved these changes
May 17, 2024
marekmatej
approved these changes
May 17, 2024
uLipe
approved these changes
May 20, 2024
|
@nashif, can you take a look please? |
carlescufi
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RTC subsystem in Espressif's SOCs, among other tasks, is responsible for clock selection for CPU and for low power domain clocks such as RTC_SLOW and RTC_FAST.
This commit allows for proper clock source and rate selection for CPU, using the espressif,riscv and espressif,xtensa-lx6/7 bindings.
It also enables clock selection for RTC_FAST and RTC_SLOW, that impacts some peripherals, such as rtc_timer.
It adds also changes for making the clock control api tests generic for any board.
All the device subsys definitions were moved to its own folder according to the clock compatible.
If the clock's async feature is not supported by the target, the test is skipped instead of failed.
Finally, it add tests for the rtc clk subsystem itself.