Abort compiling SSLPlugin if OpenSSL version below 0.9.8f #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed SNI hostname check for SSL 1.1.0
|
0x00908070 is probably 0.9.8g |
|
0x00908070 is probably 0.9.8g
I’m sure I downloaded exactly 0.9.8f to check the version. Can’t double check right now, I’ll do it tomorrow
|
|
openssl-0.9.8g, crypto/opensslv.h: openssl-0.9.8f: 0x00908070L is correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3proxy documentation never mentions which OpenSSL version is good enough for the SSLPlugin to be build. I added a compilation conditional error in case the library version is too low to support SNI. Fixes pr #218