Refactor charging function #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the `else` from the top level of the charging() function, the logic is the same but slightly easier to read now. * Use os.path.exists() in the charging() function before opening the file instead of FileNotFoundError exceptions, makes the function a lot easier to read. * Close the power_supply_type_path after reading the supply_type as it is not used later. * Remove `else: continue` from the end of the charging() function for loop, this didn't actually do anything. I tested the charging() function on my laptop plugged in and plugged out and it is still working as expected with these changes.
|
LGTM! Thank you for your contribution, you will be credited for your work as part of future release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
elsefrom the top level of the charging() function, the logic is the same but slightly easier to read now.Use
if not x.exists()in the charging() function before opening the file instead of FileNotFoundError exceptions, makes the function a lot easier to read.Close the power_supply_type_path after reading the supply_type as it is not used later.
Remove
else: continuefrom the end of the charging() function for loop, this didn't actually do anything.I tested the charging() function on my laptop plugged in and plugged out and it is still working as expected with these changes.