Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: timer field #5349

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: timer field #5349

wants to merge 19 commits into from

Conversation

zoli
Copy link
Contributor

@zoli zoli commented May 16, 2024

Timer field type which stores time in minutes. More details about this feature on the related issue #4083.
Resolves #4083.

Feature Preview

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

zoli added 9 commits May 11, 2024 23:55
@zoli
feat: wip timer field
ea3bd9d
@zoli
style: merge main resolve conflict
464d18b
@zoli
feat: timer field fixing errors
fcff838
@zoli
feat: wip timer field frontend
d1feb83
@zoli
fix: parsing TimerCellDataPB
ec757ba
@zoli
feat: parse time string to minutes
90ce5f1
@zoli
fix: don't allow none number input
ecb58e1
@zoli
fix: timer filter
7be4b1e
@zoli
style: Merge branch 'main' into feat/time-field-type-2
22b845f 
* main:
  chore: update German translations with Fink 🐦 (AppFlowy-IO#5335)
  chore: bump version 0.5.8 (AppFlowy-IO#5341)
  fix: add space above logo (AppFlowy-IO#5334)
  feat: adjust font background color in dark mode (AppFlowy-IO#5333)
  feat: support enter to insert new line in callout (AppFlowy-IO#5331)
  chore: update translations with Fink 🐦 (AppFlowy-IO#5321)
  fix: font family warning (AppFlowy-IO#5329)
  fix: show windows title bar on sign in screen (AppFlowy-IO#5326)
  fix: view action not working (AppFlowy-IO#5325)
  fix: text update bug on number/url fields (AppFlowy-IO#5315)
  feat: settings manage data (AppFlowy-IO#5265)
  chore: improve floating mobile toolbar animation for iOS (AppFlowy-IO#5309)
  chore: udpated yrs to v0.18.8 (AppFlowy-IO#5316)
  fix: page style issues (AppFlowy-IO#5317)
  feat: custom windows title bar (AppFlowy-IO#5311)
@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 26 warning contribute (via Fink 🐦)

@Xazin Xazin requested review from Xazin and LucasXu0 May 17, 2024 08:36
@Xazin Xazin added the v0.5.9 label May 18, 2024
@zoli
style: Merge branch 'main' into feat/time-field-type-2
bcc6171 
* main:
  fix: unable to remove the remote selection when the user close the page on mobile (AppFlowy-IO#5376)
  chore: add limitation when importing csv file (AppFlowy-IO#5381)
  fix: infinite loop when getting ancestor for orphan view (AppFlowy-IO#5375)
  fix: range error raise if heading level >= 6 (AppFlowy-IO#5373)
  fix: use full update states instead of patch update (AppFlowy-IO#5371)
  chore: update translations to consistently use appName instead of AppFlowy (AppFlowy-IO#5354)
  fix: changing field type from text to checkbox causes exception AppFlowy-IO#5360 (AppFlowy-IO#5366)
  fix: heading node validate failed (AppFlowy-IO#5370)
  chore: support Ukrainian language AppFlowy-IO#5350 (AppFlowy-IO#5369)
  chore: do not use the cell of given summary field (AppFlowy-IO#5362)
  chore: update translations with Fink 🐦 (AppFlowy-IO#5322)
  chore: update fr-FR.json (AppFlowy-IO#5356)
  fix: workspace icon displays incorrectly on Linux (AppFlowy-IO#5358)
  feat: support web grid preview (AppFlowy-IO#5353)
@zoli
Copy link
Contributor Author

zoli commented May 21, 2024

2024-05-21.13-03-00.mp4

@Xazin
Copy link
Collaborator

Xazin commented May 29, 2024

Also something I was thinking about when I saw "Timer", is that I was expecting it to count down. Otherwise I guess calling it "Time" is more relevant.

@zoli
Copy link
Contributor Author

zoli commented May 30, 2024

Also something I was thinking about when I saw "Timer", is that I was expecting it to count down. Otherwise I guess calling it "Time" is more relevant.

You are right about timer but I think maybe stopwatch is a better name. I also want to add time tracking feature to this later and it works like count up.

@zoli
Copy link
Contributor Author

zoli commented May 31, 2024

Thinking about this, It can be a general field type (I'm not sure about the name) which the user can choose to be a timer (count down) or stopwatch (count up) in type options. What do you think @Xazin?

@Xazin
Copy link
Collaborator

Xazin commented May 31, 2024 •
edited

Thinking about this, It can be a general field type (I'm not sure about the name) which the user can choose to be a timer (count down) or stopwatch (count up) in type options. What do you think @Xazin?

Yeah that is a good idea. Kind of like selecting a number format.

@zoli
Copy link
Contributor Author

zoli commented May 31, 2024

So I will change the field type name to Time and will add a stopwatch and timer option later in a separate PR.

@Xazin
Copy link
Collaborator

Xazin commented May 31, 2024

So I will change the field type name to Time and will add a stopwatch and timer option later in a separate PR.

Sounds good, feel free to ping me when you have renamed the field, I tested and feature works as expected. 👍

I think the time type data can be in minutes, but for Stop timer or Count down timer, it should be a start timestamp.

zoli added 5 commits June 2, 2024 10:25
@zoli
refactor: rename field type timer to time
bcdbda5
@zoli
style: Merge branch 'main' into feat/time-field-type-2
fae5607 
* main: (25 commits)
  fix: sidebar issues (AppFlowy-IO#5444)
  fix: notification test (AppFlowy-IO#5440)
  fix: some list icons don't align with the paragraph (AppFlowy-IO#5439)
  feat: integrate show notification button option (AppFlowy-IO#5302)
  feat: add border to selected unsplash image (AppFlowy-IO#5428)
  feat: sidebar UI Revamp on mobile (AppFlowy-IO#5418)
  chore: update German translations with Fink 🐦 (AppFlowy-IO#5421)
  chore: update Spanish translations (AppFlowy-IO#5205)
  feat: video block support (AppFlowy-IO#5199)
  feat: add reset app scale hotkey (AppFlowy-IO#5386)
  fix: sidebar issues on Windows and Linux (AppFlowy-IO#5431)
  feat: support web layout setting and breadcrumbs (AppFlowy-IO#5425)
  fix: dragging the Unsplash cover triggers an assertion error (AppFlowy-IO#5404)
  chore: improve hover and text colors in dark mode (AppFlowy-IO#5416)
  fix: accept multi-key combination for customizing shortcuts & removes duplicates (AppFlowy-IO#5414)
  feat: sidebar UI Revamp on Desktop (AppFlowy-IO#5343)
  fix: default text direction not synced (AppFlowy-IO#5405)
  chore: update German translations (AppFlowy-IO#5382)
  feat: support preview grid/board/calendar block on web (AppFlowy-IO#5401)
  feat: support open row page (AppFlowy-IO#5400)
  ...
@zoli
refactor: missed some variable and files to rename
0729b6e
@zoli
style: cargo fmt fix
3c16e29
@zoli
feat: format time field type data in frontend
6c66523
@zoli
Copy link
Contributor Author

zoli commented Jun 2, 2024

@Xazin I renamed the field type to time and moved the formatting function to the flutter frontend.
I will implement these features on other PRs:

  • Having precision option (store by minutes or second)
  • Timer and Stopwatch as type option
  • More localization support as per your review comment.
  • Tracking time button for timer and stopwatch

@Xazin Xazin added v0.6.0 and removed v0.5.9 labels Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xazin Xazin Xazin left review comments

@LucasXu0 LucasXu0 Awaiting requested review from LucasXu0

Assignees
No one assigned
Labels
v0.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Time field type
2 participants
@zoli @Xazin