Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Profiler: Wrap logic inside an AdvancedMetrics component #90765

Merged
merged 1 commit into from
May 16, 2024
Merged

Site Profiler: Wrap logic inside an AdvancedMetrics component #90765

merged 1 commit into from
May 16, 2024

Conversation

WBerredo
Copy link
Collaborator

Fixes #90704

Proposed Changes

Wrap some logic inside an AdvancedMetrics component.
This component will also be responsible to handle the request to retrieve data for those components.

Why are these changes being made?

It was a reasonable ask here #90662 (comment)

Testing Instructions

  • Go to /site-profiler/:url. Ex: /site-profiler/example.com
  • Scroll down and check if everything still working as before.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited by matticbot

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-107847
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-107847&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-107847&env=a8c-for-agencies

@WBerredo WBerredo force-pushed the add/site-profiler-advanced-metrics branch from 823a882 to 9bfce62 Compare May 15, 2024 17:08
@WBerredo WBerredo requested a review from epeicher May 15, 2024 17:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2024
@matticbot
Copy link
Contributor

matticbot commented May 15, 2024 •
edited

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~406 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
site-profiler      +1081 B  (+1.1%)     +406 B  (+1.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/site-profiler-advanced-metrics on your sandbox.

@WBerredo WBerredo mentioned this pull request May 15, 2024
Closed
@WBerredo WBerredo linked an issue May 15, 2024 that may be closed by this pull request
Create the AdvancedMetrics component #90704
Closed
@JulianBustamante JulianBustamante self-requested a review May 16, 2024 03:22
JulianBustamante
JulianBustamante approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@JulianBustamante JulianBustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

example_com _ Site Profiler _ WordPress_com

@WBerredo WBerredo merged commit 83167b8 into add/metrics-list-blur May 16, 2024
14 checks passed
@WBerredo WBerredo deleted the add/site-profiler-advanced-metrics branch May 16, 2024 12:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 16, 2024
@WBerredo WBerredo restored the add/site-profiler-advanced-metrics branch May 16, 2024 13:50
@WBerredo WBerredo deleted the add/site-profiler-advanced-metrics branch May 16, 2024 13:51
@epeicher
Copy link
Contributor

Thanks for this @WBerredo! This simplifies the main screen and leave changes to the advanced metrics isolated to its own context 🙌

WBerredo added a commit that referenced this pull request May 16, 2024
@WBerredo
Site Profiler: Wrap logic inside a AdvancedMetrics component (#90765)
5a7b6c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianBustamante JulianBustamante JulianBustamante approved these changes

@epeicher epeicher Awaiting requested review from epeicher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create the AdvancedMetrics component
4 participants
@WBerredo @matticbot @epeicher @JulianBustamante