-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Profiler: Wrap logic inside an AdvancedMetrics component #90765
Site Profiler: Wrap logic inside an AdvancedMetrics component #90765
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
a7f1dc6
to
e2f6bc1
Compare
823a882
to
9bfce62
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~406 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @WBerredo! This simplifies the main screen and leave changes to the advanced metrics isolated to its own context 🙌 |
Fixes #90704
Proposed Changes
Wrap some logic inside an AdvancedMetrics component.
This component will also be responsible to handle the request to retrieve data for those components.
Why are these changes being made?
It was a reasonable ask here #90662 (comment)
Testing Instructions
/site-profiler/:url
. Ex:/site-profiler/example.com
Pre-merge Checklist