Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update domains table style #90827

Merged
merged 6 commits into from
May 20, 2024
Merged

Fix/update domains table style #90827

merged 6 commits into from
May 20, 2024

Conversation

roo2
Copy link
Contributor

@roo2 roo2 commented May 17, 2024

Fixes most of 7169-gh-Automattic/dotcom-forge

We can make these two tables more consistent:
Add hover state to the domains table.

Table headers are the same for both tables (Font sizes, color, etc).

This PR tidies up padding, alignment and heights so that the domains table matches the sites table on all resolutions. I also tidied up alignment of the sites table header.

before:
Screenshot 2024-05-20 at 8 58 18 am

after:
Screenshot 2024-05-20 at 8 58 09 am

Sites table header:

before:
Screenshot 2024-05-20 at 8 49 17 am

after:

Screenshot 2024-05-20 at 8 49 23 am

Note: I haven't dealt with table widths on the domains table, because it has quite a complex display method that is different from the sites table, we can work on that in another PR

Testing instructions

Ensure that /domains/manage and /sites table headers are similar at all resolutions.

@roo2 roo2 requested a review from a team as a code owner May 17, 2024 02:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 17, 2024
@matticbot
Copy link
Contributor

matticbot commented May 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~42 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +278 B  (+0.0%)      +42 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@roo2 roo2 force-pushed the fix/update-domains-table-style branch from 7921275 to 9023c6d Compare May 19, 2024 22:47
@roo2 roo2 requested review from a team as code owners May 19, 2024 22:47
@roo2 roo2 requested review from DustyReagan, eoigal, Addison-Stavlo and a team and removed request for a team May 19, 2024 22:47
Base automatically changed from fix/sites-width to trunk May 19, 2024 23:51
@roo2 roo2 force-pushed the fix/update-domains-table-style branch from 9023c6d to 26f6548 Compare May 20, 2024 00:15
@roo2
Copy link
Contributor Author

roo2 commented May 20, 2024

If anyone is testing this, here a trick to check that the paddings match between the /sites page and the /domains/manage page in chrome:

Open /sites page in one tab
Open /domains/manage in another tab.
Open dev tools in tab#1, choose a size.
In tab#2, close the dev tools, then re-open them. This will cause the dev tools to be sized the same in both tabs.
flick back and forth between the tabs, compare the pages.
Adjust dev tools in tab#1 to choose a new width.
In tab#2, close and open the dev tools again, they will get the same width as tab#1
repeat.

Just a trick that works in chrome, it also works when selecting a responsive width, it's also useful for comparing with wordpress.com.

Screen.Recording.2024-05-20.at.10.13.38.am.mov

@roo2 roo2 force-pushed the fix/update-domains-table-style branch from 26f6548 to a3ddd9f Compare May 20, 2024 03:15
@@ -37,22 +37,22 @@
// Note: The checkbox does not count for column counting purposes

&.is-7-column {
grid-template-columns: 20px 2fr 1fr 1fr auto auto auto auto;
grid-template-columns: 20px 2fr 1fr 1fr auto auto auto 36px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, bad rebase here.

@@ -104,10 +104,6 @@
.domains-table__row {
&:has(a.domains-table__domain-name) {
cursor: pointer;

&:hover td {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad rebase here as well

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/update-domains-table-style on your sandbox.

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@roo2 roo2 merged commit 5dae7b8 into trunk May 20, 2024
11 checks passed
@roo2 roo2 deleted the fix/update-domains-table-style branch May 20, 2024 04:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants