-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update domains table style #90827
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~42 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
7921275
to
9023c6d
Compare
9023c6d
to
26f6548
Compare
If anyone is testing this, here a trick to check that the paddings match between the /sites page and the /domains/manage page in chrome: Open Just a trick that works in chrome, it also works when selecting a responsive width, it's also useful for comparing with wordpress.com. Screen.Recording.2024-05-20.at.10.13.38.am.mov |
26f6548
to
a3ddd9f
Compare
@@ -37,22 +37,22 @@ | |||
// Note: The checkbox does not count for column counting purposes | |||
|
|||
&.is-7-column { | |||
grid-template-columns: 20px 2fr 1fr 1fr auto auto auto auto; | |||
grid-template-columns: 20px 2fr 1fr 1fr auto auto auto 36px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, bad rebase here.
@@ -104,10 +104,6 @@ | |||
.domains-table__row { | |||
&:has(a.domains-table__domain-name) { | |||
cursor: pointer; | |||
|
|||
&:hover td { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad rebase here as well
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 👍
Fixes most of 7169-gh-Automattic/dotcom-forge
This PR tidies up padding, alignment and heights so that the domains table matches the sites table on all resolutions. I also tidied up alignment of the sites table header.
before:
after:
Sites table header:
before:
after:
Note: I haven't dealt with table widths on the domains table, because it has quite a complex display method that is different from the sites table, we can work on that in another PR
Testing instructions
Ensure that /domains/manage and /sites table headers are similar at all resolutions.