Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Update WooPayments revenue share copy #90858

Merged
merged 1 commit into from
May 20, 2024

Conversation

rcanepa
Copy link
Contributor

@rcanepa rcanepa commented May 17, 2024

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/502

Proposed Changes

  • Replace gross merchandise value with total payments volume (TPV).

Why are these changes being made?

  • Accurately represent the terms of revenue share.

Testing Instructions

  • Either locally or via Live Branch, visit /referrals.
  • Verify that the WooPayments card (the last one) displays the copy change mentioned in this PR's description.
Before After
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@rcanepa rcanepa added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Size] XS Tiny sized issue A8c Agencies A4A labels May 17, 2024
@rcanepa rcanepa requested a review from a team May 17, 2024 18:50
@rcanepa rcanepa self-assigned this May 17, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcanepa rcanepa merged commit 944422c into trunk May 20, 2024
14 checks passed
@rcanepa rcanepa deleted the fix/a4a/woopayments-revenue-share-copy branch May 20, 2024 02:05
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants