-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding for Azure Security Baseline v2's EnsurePasswordReuseIsLimited check remediation and consolidating audit #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjaeger
reviewed
May 17, 2024
simonjaeger
approved these changes
May 17, 2024
robertschaedler3
approved these changes
May 17, 2024
…d consolidating audit
AhmedBM
reviewed
May 17, 2024
AhmedBM
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but curious about the function expansions.
AhmedBM
approved these changes
May 17, 2024
robertschaedler3
approved these changes
May 17, 2024
robertschaedler3
approved these changes
May 17, 2024
simonjaeger
approved these changes
May 17, 2024
MariusNi
changed the title
Securing recently added ASB v2 remediation checks for updating PAM and other system files
Adding for Azure Security Baseline v2's EnsurePasswordReuseIsLimited check remediation and consolidating audit
May 17, 2024
simonjaeger
reviewed
May 20, 2024
simonjaeger
approved these changes
May 20, 2024
robertschaedler3
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR started with ensuring the manner in which system files are not directly updated but instead, copied to a temporary copy, edited there then atomically renamed at the very end. Adding implementation for EnsurePasswordReuseIsLimited's remediation and consolidating audit, plus fixing implementation for the EnsureAvahiDaemonServiceIsDisabled and EnsureCupsServiceisDisabled's remediation, also adding several remediations based on added configuration files to disable certain components, under /etc/modprobe.d.
Checklist
main
branch prior to this PR submission.main
branch.