[keyvault] fix test recording sanitizers #22911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracewilcox
requested review from
benbp,
weshaggard,
chlowell and
jhendrixMSFT
as code owners
chlowell
reviewed
May 31, 2024
| require.NotNil(t, roleDefinition.Type) | ||
|
|
||
| if *roleDefinition.ID == *updatedDefinition.ID { | ||
| updatedDefinitionCount++ |
There was a problem hiding this comment.
🤔 it would be nice to cover the pager in playback and you could do that if ID weren't sanitized, or you didn't assert on updatedDefinitionCount in playback. Either works but I'd probably disable the sanitizer because this ID isn't secret, then double check that there isn't some other ID which is secret.
| @@ -48,7 +45,13 @@ func TestRoleDefinition(t *testing.T) { | |||
| // test create definition | |||
| createdDefinition, err := client.CreateOrUpdateRoleDefinition(context.Background(), scope, name, parameters, nil) | |||
| require.NoError(t, err) | |||
| require.Equal(t, name, *createdDefinition.Name) | |||
|
|
|||
| if recording.GetRecordMode() == recording.PlaybackMode { | |||
There was a problem hiding this comment.
I suggest either removing the name sanitizer (should be this one, names in these tests aren't secret) or asserting only in recording & live modes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22869
Fixing tests to be compatible in playback mode with the new test sanitizers