-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds injectionRate to FaultInjectionServerErrorResult #40213
Adds injectionRate to FaultInjectionServerErrorResult #40213
Conversation
...test/src/main/java/com/azure/cosmos/test/faultinjection/FaultInjectionServerErrorResult.java
Outdated
Show resolved
Hide resolved
...test/src/main/java/com/azure/cosmos/test/faultinjection/FaultInjectionServerErrorResult.java
Outdated
Show resolved
Hide resolved
...test/src/main/java/com/azure/cosmos/test/faultinjection/FaultInjectionServerErrorResult.java
Outdated
Show resolved
Hide resolved
...azure/cosmos/test/implementation/faultinjection/FaultInjectionServerErrorResultInternal.java
Outdated
Show resolved
Hide resolved
.../java/com/azure/cosmos/test/implementation/faultinjection/FaultInjectionServerErrorRule.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for few small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great @NaluTripician , thank you.
Please add some more testing cases.
...test/src/main/java/com/azure/cosmos/test/faultinjection/FaultInjectionServerErrorResult.java
Outdated
Show resolved
Hide resolved
.../java/com/azure/cosmos/test/implementation/faultinjection/FaultInjectionServerErrorRule.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/azure/cosmos/faultinjection/FaultInjectionServerErrorRuleOnDirectTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Description
Adds Application Percentage for ServerErrorRules. This allows users to specify how frequently server error rules are applied. For instance, by setting this value to
.5
that rule will be applied 50% of the time. This value is 1, or 100%, by default.Mirror
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines