Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements fic credential #44108

Closed
wants to merge 3 commits into from

Conversation

dinazavyr
Copy link

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@dinazavyr dinazavyr requested a review from a team as a code owner May 17, 2024 12:22
@dinazavyr
Copy link
Author

/azp run net - Azure.Communication.SMS - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinazavyr: Please add context to the description explaining the problem that you're attempting to solve and the scenarios that it applies to. Please also help us understand whether or not you've been working with a member of the Azure SDK team to advise on this submission.

Since this looks to be applicable to Communication.SMS, can you help us understand why you believe this change should be made in Azure.Core versus being applied locally in the Communication.SMS library?

@dinazavyr
Copy link
Author

/azp run net - Azure.Communication.SMS - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dinazavyr
Copy link
Author

/azp run net - Azure.Communication.SMS - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsquire
Copy link
Member

jsquire commented May 28, 2024

Given that we do not intend to move forward with this change in the Core framework at this time and inquires have gone unanswered, closing this out. If this is functionality necessary for the Communications library, please implement in the local test environment.

@jsquire jsquire closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants