-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Switch from ClientSecretCredential
to DefaultAzureCredential
#35651
Open
vincenttran-msft
wants to merge
7
commits into
Azure:main
Choose a base branch
from
vincenttran-msft:vincenttran/fix_oauth
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Storage] Switch from ClientSecretCredential
to DefaultAzureCredential
#35651
vincenttran-msft
wants to merge
7
commits into
Azure:main
from
vincenttran-msft:vincenttran/fix_oauth
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenttran-msft
requested review from
scbedd,
mccoyp,
annatisch,
jalauzon-msft and
weirongw23-msft
as code owners
May 15, 2024 23:04
API change check API changes are not detected in this pull request. |
6 tasks
mccoyp
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We'll keep an eye out for any usability quirks and make things more Storage setup-compatible if necessary.
/azp run python - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to move away from using discrete
ClientSecretCredential
for OAuth operations and to instead now useDefaultAzureCredential
.This also means that you have to routinely do
az login
when running OAuth tests to refresh your permission, but will get away from those pesky secrets 馃槃TODO: