Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raising a work around for command job and spark job name lowering case #35688

Merged
merged 14 commits into from
Jun 4, 2024

Conversation

achauhan-scc
Copy link
Member

@achauhan-scc achauhan-scc commented May 17, 2024

Description

Problem:

Updates of job are failing using SDK V2. Two issues

  • SDK is failing to parse the API response.
  • Even only allowed properties (Tags) are modified, API validation is failing claiming other properties are modified.

Fixes:

  • "from_rest_object" of Sweep Job is not converting API object to SDK object for objective property which causing a failure, as a fix converting objective to SDK object, sweep_job.py (330)
  • while fetching the job from API SDK is using older version of rest object which causing to drop a property resource as fix repopulating that value from trails, (API is also doing the similar logic) -> sweep_job.py (271 - 274)
  • API is sending the fully qualified path for environment, SDK was missing a check of is_ARM_id_for_resource, before calling the resolver, as fix added the check so SDK do not resolve the environment path if its fully qualified. -> job_operations.py (1476 - 1480)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@achauhan-scc achauhan-scc merged commit 19c386b into Azure:main Jun 4, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants