Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emoji from @types/mdast #69584

Conversation

remcohaszing
Copy link
Contributor

This is a workaround for nodejs/node#52797.

Please fill in this template.

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 13, 2024

@remcohaszing Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69584,
  "author": "remcohaszing",
  "headCommitOid": "19a6fbcb026b7300d6024f5c457b58c8e6f9bfad",
  "mergeBaseOid": "213785ea0d09abc2b89228d0a810e1597fabb18f",
  "lastPushDate": "2024-05-13T08:48:05.000Z",
  "lastActivityDate": "2024-05-14T07:24:57.000Z",
  "mergeOfferDate": "2024-05-13T21:08:32.000Z",
  "mergeRequestDate": "2024-05-14T07:24:57.000Z",
  "mergeRequestUser": "remcohaszing",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "mdast",
      "kind": "edit",
      "files": [
        {
          "path": "types/mdast/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ChristianMurphy",
        "lujun2",
        "remcohaszing",
        "wooorm",
        "remcohaszing"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-05-13T20:05:58.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "ChristianMurphy",
      "date": "2024-05-13T19:40:22.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "wooorm",
      "date": "2024-05-13T08:49:58.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2107001389,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels May 13, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 13, 2024
@typescript-bot
Copy link
Contributor

Hey @remcohaszing,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @ChristianMurphy @lujun2 @wooorm — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@wooorm
Copy link
Contributor

wooorm commented May 13, 2024

Note that this makes your repro of that bug stop working. When this lands, you’d likely want to update that repro / tell people about it!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 13, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 13, 2024
@remcohaszing
Copy link
Contributor Author

remcohaszing commented May 13, 2024

No, the repro has a lockfile. Also this PR description creates a reference to the issue.

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jakebailey
Copy link
Member

@typescript-bot ping

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 13, 2024
@typescript-bot
Copy link
Contributor

@remcohaszing: Everything looks good here. I am ready to merge this PR (at 19a6fbc) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ChristianMurphy, @lujun2, @wooorm: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board May 13, 2024
@remcohaszing
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 14, 2024
@typescript-bot typescript-bot merged commit 884f5f5 into DefinitelyTyped:master May 14, 2024
4 checks passed
@remcohaszing remcohaszing deleted the mdast-node-segfault-workaround branch May 14, 2024 07:33
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 14, 2024
wooorm added a commit to unifiedjs/unified that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants