-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: re-enable connectors, bump dependencies #2210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If only all PRs were one-liners!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assume we'll wait for @fuels/connectors has been updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, is it possible to uncomment this already?
Is the connectors package using fuels
0.83
already?
The relationship between Because one depends on the other, their cyclic dependency should always hunt us and delay releases. |
You are right here. I suppose we have a number of options:
Any others that I've missed? I'd say that after #2170 has been completed, we'll be in a better position to gauge whether option 1 is viable. |
I just checked. There is indeed a version mis-match here. Marking this as blocked until the wallet SDK bumps their TS SDK version |
create-fuels
templatecreate-fuels
template, bump dependencies
d0fb235
create-fuels
template, bump dependencies
Coverage Report:
Changed Files:Coverage values did not change👌. |
This PR re-enables all the default connectors in the
create-fuels
template, and bumps@fuels/react
and@fuels/connectors
to their latest versions.Closes #2171