Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add forc-doc impls for enums and fix sidebar #6020

Merged
merged 10 commits into from
May 19, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented May 16, 2024

Description

Closes #6018

Makes trait & inherent implementations show up for enums now:
image

And makes the sidebar include links to the impls:
image

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review May 16, 2024 00:52
@sdankel sdankel requested a review from a team May 16, 2024 00:52
@sdankel sdankel changed the title fix: add forc-doc impls for enums fix: add forc-doc impls for enums and fix sidebar May 16, 2024
@kayagokalp kayagokalp added enhancement New feature or request forc-doc Everything related to the `forc doc` command plugin. labels May 17, 2024
JoshuaBatty
JoshuaBatty previously approved these changes May 17, 2024
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is great to see, just one tiny nit.

kayagokalp
kayagokalp previously approved these changes May 17, 2024
@sdankel sdankel dismissed stale reviews from kayagokalp and JoshuaBatty via a2b1e97 May 17, 2024 19:49
@sdankel sdankel enabled auto-merge (squash) May 17, 2024 19:50
@sdankel sdankel merged commit f9a72da into master May 19, 2024
37 checks passed
@sdankel sdankel deleted the sophie/forc-doc-impl-enums branch May 19, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request forc-doc Everything related to the `forc doc` command plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forc-doc implementations missing from sidebar and enums
3 participants