Replace Jinja2 variables in Document Core Properties #397
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this! Due to the reporting engine undergoing a complete refactoring last month, we can't merge this as is. We'll need to adapt it for the new reporting library. If you'd like to tackle that, have a look at it here: https://github.com/GhostManager/Ghostwriter/tree/v4-1-dev/ghostwriter/modules/reportwriter That's part of the current release candidate. I'm giving it a couple more weeks for feedback. Barring any major issues, I expect to make it the final release the first week of April. |
ColonelThirtyTwo
added a commit
to ColonelThirtyTwo/Ghostwriter
that referenced
this pull request
Mar 29, 2024
Based on code by @domwhewell-sage's PR [1], edited for the report writer refactoring. [1]: GhostManager#397
ColonelThirtyTwo
added a commit
to ColonelThirtyTwo/Ghostwriter
that referenced
this pull request
Apr 5, 2024
Based on code by @domwhewell-sage's PR [1], edited for the report writer refactoring. [1]: GhostManager#397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add jinja2 variables in the Document/PowerPoint properties (File > Info >> Properties). #389
You can add jinja2 variables into the Core properties in office documents so they will be replaced upon generation.
The properties dictionary in the
_add_office_properties()function represents properties that can be accessed in both word and PowerPoint documents.Whilst researching this I found there are some document properties in office documents that are not currently accessible to python-docx/python-pptx python-openxml/python-docx#91 but hopefully this PR satisfies the basic properties.