Oplog full-text-search take two #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColonelThirtyTwo
force-pushed
the
oplog-fts
branch
from
471b2c6
to
4c1f3f2
Compare
This patch enables searching of tags and extra fields. The downside is that we can't build an FTS index, since the tags are in a different table and the extra fields are user-editable. In the future, we can look into storing the compiled SearchVector as a field in the OplogEntry, updating it whenever the entry or its tags change, and indexing that.
ColonelThirtyTwo
force-pushed
the
oplog-fts
branch
from
4c1f3f2
to
9765ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables searching of tags and extra fields. The downside is that we can't build an FTS index, since the tags are in a different table and the extra fields are user-editable.
In the future, we can look into storing the compiled SearchVector as a field in the OplogEntry, updating it whenever the entry or its tags change, and indexing that.
I haven't tested this with a large amount of entries in one log. We should make sure that it has acceptable performance.