Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tika: fix server jar script #169672

Merged
merged 2 commits into from
May 20, 2024
Merged

tika: fix server jar script #169672

merged 2 commits into from
May 20, 2024

Conversation

andreasnef
Copy link
Contributor

Fix for #169663

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the java Java use is a significant feature of the PR or issue label Apr 21, 2024
@carlocab carlocab changed the title tika 2.9.2 tika: fix server jar script Apr 21, 2024
@chenrui333 chenrui333 force-pushed the fix-tika branch 2 times, most recently from eb286c1 to 11edcbe Compare April 24, 2024 04:49
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Apr 24, 2024
SMillerDev
SMillerDev reviewed Apr 24, 2024
View reviewed changes
Formula/t/tika.rb Outdated
Comment on lines 23 to 24
odie "server resource needs to be updated" if version != resource("server").version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add this to the test block as a check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I will do later in a bit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I see your point, I think we'd. prefer to have odie in the install so that we dont need to wait for the test to check on the resource sync thing. Let me know if that makes sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with bunch of similar build change PRs on the resource sync issue

@chenrui333 chenrui333 removed the ready to merge PR can be merged once CI is green label Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 25, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 25, 2024
SMillerDev
SMillerDev reviewed Apr 25, 2024
View reviewed changes
Formula/t/tika.rb Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label May 17, 2024
@SMillerDev SMillerDev enabled auto-merge May 17, 2024 08:19
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 17, 2024
@branchvincent branchvincent removed the stale No recent activity label May 20, 2024
@SMillerDev SMillerDev added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@andreasnef @branchvincent
tika: fix server jar script
24fc424 
fixes Homebrew#169663

tika: ensure resource in sync

tika: revision bump

Signed-off-by: Rui Chen <rui@chenrui.dev>

tika: add server start check

Signed-off-by: Rui Chen <rui@chenrui.dev>

tika: bump sleep time

Signed-off-by: Rui Chen <rui@chenrui.dev>
@branchvincent branchvincent added the ready to merge PR can be merged once CI is green label May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 20, 2024
Merged via the queue into Homebrew:master with commit fd90449 May 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

@branchvincent branchvincent branchvincent approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. java Java use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andreasnef @SMillerDev @chenrui333 @branchvincent @BrewTestBot