Race condition on looped sounds #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame time the .ended callback is called it would re-start the sound, despite that the .stop() was called.
|
Hi, thanks for that investigation. I will check this soon. |
…sed to disable the 'disable cache by default' mechanism in ion.sound
# Conflicts: # js/ion.sound.js
|
I'd also added an option called 'allow_cache', which would allow developers to disable the 'no cache' functionality. |
|
Any progress with this? |
|
Hi, @lpetrov, sorry, had no time to work on it in 2017. But i promise i will review everything regarding ion.sound in the beginning of 2018! Happy New Year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, this one is really, really, really hard to replicate.
I'd to reload tons of times to try to replicate it and it happens randomly.
So, the thing is that, when a sound had been manually .stop()'ped, browsers as Firefox, can eventually trigger the .ended callback few moments after the .stop() call, which would trigger the sound to loop again.
This is why, I'd added this small additional check that should solve potential race conditions as this one :)