feat: folder inheritance scripts #7430
Open
+73
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
changed the title
jackkav
changed the title
jackkav
changed the title
jackkav
force-pushed
the
feat/script-inheritance
branch
from
56ee1a1
to
1f2a87e
Compare
jackkav
force-pushed
the
feat/script-inheritance
branch
from
0a8579d
to
cabfe9e
Compare
ihexxa
reviewed
May 27, 2024
| @@ -18,7 +18,7 @@ interface BaseRequestGroup { | |||
| environmentPropertyOrder: Record<string, any> | null; | |||
| metaSortKey: number; | |||
| preRequestScript: string; | |||
| postRequestScript: string; | |||
| afterRequestScript: string; | |||
There was a problem hiding this comment.
we might named it as afterResponseScript after merging.
| title={ | ||
| <div className='flex items-center gap-2'> | ||
| After-request Script{' '} | ||
| {activeRequestGroup.preRequestScript && ( |
There was a problem hiding this comment.
It should be activeRequestGroup.afterResponseScript instead preXX.
| } | ||
| await fn${i}(); | ||
| `); | ||
| const joinedScript = [...folderScripts].join('\n'); |
There was a problem hiding this comment.
we might also think about things like displaying progress or proper timeout value for joined scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
closes INS-3860
challenges