Improve Lawnchair documentation #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Fix NullCube's tomfoolery"
Co-authored-by: Pun Butrach <pun.butrach@gmail.com>
Proofread CONTRIBUTING.md
Signed-off-by: validcube <pun.butrach@gmail.com>
…to pave-path Signed-off-by: validcube <pun.butrach@gmail.com>
Signed-off-by: validcube <pun.butrach@gmail.com>
Final proofread
Script Execution UTC Time: 2024-05-17T17:02:33.603063+00:00 Signed-off-by: validcube <pun.butrach@gmail.com>
Script Execution UTC Time: 2024-05-17T17:05:58.625257+00:00 Signed-off-by: validcube <pun.butrach@gmail.com>
SuperDragonXD
requested changes
May 25, 2024
There was a problem hiding this comment.
Nice work on adding documentation! Apologies for the delay in reviewing as well.
While the text is mostly great, I'd suggest several changes to make it more consistent with Lawnchair’s tone and clarify some text.
For CONTRIBUTING.md, it would also be nice for us to include some chats in Discord/Telegram for help. We don't really need to bold all instances of LAWNCHAIR either.
Lastly, please add newlines to the end of the files if there isn't already.
Once again, thanks for the PR!
Co-authored-by: SuperDragonXD <70206496+SuperDragonXD@users.noreply.github.com>
README.md
Outdated
Comment on lines
12
to
13
| <source media="(prefers-color-scheme: dark)" srcset="docs/device-frame.png" width="15%"> | ||
| <img alt="Google Pixel running Lawnchair Launcher with green wallpaper" src="docs/device-frame.png" width="15%"> |
There was a problem hiding this comment.
Just tested it on small devices, and it's quite small due to the 15% width.
How about we hardcode it to about 250-300px in width? I personally prefer 300px, as it matches the Lawnchair website.
There was a problem hiding this comment.
250px seems to be a good size for this
SuperDragonXD
approved these changes
May 25, 2024
xteamlyer
added a commit
to xteamlyer/LawnchairRelease
that referenced
this pull request
May 28, 2024
commit 8ab7cce Author: MrSluffy <werdna.jac@gmail.com> Date: Sun May 26 10:58:51 2024 +0800 Revert "Fixed glitch for nothingOs 2.5.5" This reverts commit 15b8710. commit 15b8710 Author: MrSluffy <werdna.jac@gmail.com> Date: Sun May 26 10:29:28 2024 +0800 Fixed glitch for nothingOs 2.5.5 commit 8f33436 Author: MrSluffy <werdna.jac@gmail.com> Date: Sat May 25 18:31:28 2024 +0800 Fixed crashed on A10 samsung logs : Lawnchair bug report 25 may. 2024 3:33:41 a. m. version: 14 Dev (3ffaf14) (14000202) commit: 3ffaf14 build.brand: samsung build.device: a02 build.display: QP1A.190711.020.A022MUBS2AUH1 build.fingerprint: samsung/a02ub/a02:10/QP1A.190711.020/A022MUBS2AUH1:user/release-keys build.hardware: mt6739 build.id: QP1A.190711.020 build.manufacturer: samsung build.model: SM-A022M build.security.level: 2021-08-01 build.product: a02ub build.type: user version.codename: REL version.incremental: A022MUBS2AUH1 version.release: 10 version.sdk_int: 29 display.density_dpi: 261 isRecentsEnabled: true error: Uncaught exception java.lang.AbstractMethodError: abstract method "void android.view.IRecentsAnimationRunner.reportAllDrawn()" at android.view.IRecentsAnimationRunner$Stub.onTransact(IRecentsAnimationRunner.java:152) at android.os.Binder.execTransactInternal(Binder.java:1056) at android.os.Binder.execTransact(Binder.java:1029) commit 93738e2 Author: MrSluffy <werdna.jac@gmail.com> Date: Sat May 25 17:04:51 2024 +0800 Fixed style commit 735b721 Author: MrSluffy <werdna.jac@gmail.com> Date: Sat May 25 16:58:32 2024 +0800 Fixed crash NothingOs 2.5.5 err : java.lang.AbstractMethodError: abstract method "void android.view.IRecentsAnimationRunner.onAnimationStartWithSurfaceTransaction(android.view.IRecentsAnimationController, android.window.TransitionInfo, android.view.SurfaceControl$Transaction, android.view.RemoteAnimationTarget[], android.view.RemoteAnimationTarget[], android.graphics.Rect, android.graphics.Rect)" at android.view.IRecentsAnimationRunner$Stub.onTransact(IRecentsAnimationRunner.java:205) at android.os.Binder.execTransactInternal(Binder.java:1339) at android.os.Binder.execTransact(Binder.java:1275) commit bade8d7 Merge: 894faf6 9c1bd7b Author: John Andrew Camu <werdna.jac@gmail.com> Date: Sat May 25 13:14:18 2024 +0800 Merge branch '14-dev' into fix/crash-qpr2 commit 894faf6 Author: MrSluffy <werdna.jac@gmail.com> Date: Sat May 25 12:50:18 2024 +0800 Add support A14 QPR2 commit 9c1bd7b Author: JovannMC <jovannmc@femboyfurry.net> Date: Sat May 25 07:37:55 2024 +0300 Improve Lawnchair documentation (LawnchairLauncher#4370) upstream (squash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve the documentation of Lawnchair by creating a
CONTRIBUTING.mdand modifying the existing markdown files.Type of change
✅ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)