feat(module:menu): add click trigger for submenus #8461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vanehPA/ng-zorro-antd into feature/submenu-triggers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8461 +/- ##
==========================================
+ Coverage 91.60% 91.62% +0.02%
==========================================
Files 519 530 +11
Lines 18074 18394 +320
Branches 2848 2813 -35
==========================================
+ Hits 16557 16854 +297
- Misses 1218 1224 +6
- Partials 299 316 +17 ☔ View full report in Codecov by Sentry. |
Laffery
reviewed
Jun 2, 2024
| @@ -96,12 +97,13 @@ export class NzSubMenuTitleComponent implements OnDestroy, OnInit { | |||
| } | |||
|
|
|||
| setMouseState(state: boolean): void { | |||
| if (!this.nzDisabled) { | |||
| if ((!this.nzDisabled && this.nzTriggerSubMenuAction === 'hover') || !state) { | |||
There was a problem hiding this comment.
|| !state -> mouseLeave event will trigger closing the submenu
Laffery
reviewed
Jun 2, 2024
| this.subMenuMouseState.next(state); | ||
| } | ||
| } | ||
| clickTitle(): void { | ||
| if (this.mode === 'inline' && !this.nzDisabled) { | ||
| if ((this.mode === 'inline' || this.nzTriggerSubMenuAction === 'click') && !this.nzDisabled) { | ||
| this.subMenuMouseState.next(true); |
There was a problem hiding this comment.
- It'll be great if support closing submenu when clicking outside of the submenu-title
- Please check that sub-sub-menu will be closed recursively if closing the higher-level submeu. For example, submenu of Option3 should be closed when closing submenu of Option2
- Option 1
- Option 2
- Option 3
- Option 4
Laffery
added
PR: partially-approved
PR: reviewed-changes-requested
and removed
PR: unreviewed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In Ant design, it is possible to choose between a
clickor ahovertrigger for submenues.Issue Number: #4745
What is the new behavior?
clicktrigger implemented.Does this PR introduce a breaking change?
Other information