Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] [ASPNETCORE] Add value types for the ASPNETCORE generator #18646

Conversation

evgenii-kuznetsov
Copy link
Contributor

@evgenii-kuznetsov evgenii-kuznetsov commented May 12, 2024

Requirement: #18557

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@evgenii-kuznetsov evgenii-kuznetsov changed the title Add value types for the ASPNETCORE generator [REQ] [ASPNETCORE] Add value types for the ASPNETCORE generator May 12, 2024
@wing328
Copy link
Member

wing328 commented May 13, 2024

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented May 13, 2024

please follow step 3 to update the samples so that the CI can verify the change.

@evgenii-kuznetsov evgenii-kuznetsov force-pushed the pr/18557_aspnetcore-generator-add-value-types branch 2 times, most recently from 282232e to f52ed0d Compare May 19, 2024 15:06
@evgenii-kuznetsov evgenii-kuznetsov force-pushed the pr/18557_aspnetcore-generator-add-value-types branch from f52ed0d to 198ed68 Compare May 19, 2024 15:29
@evgenii-kuznetsov
Copy link
Contributor Author

Dear technical committee members, could you please check this pull request if you have time.
CC: @mandrean, @shibayan, @Blackclaws, @lucamazzanti, @iBicha

@wing328 wing328 merged commit 73598b9 into OpenAPITools:master May 21, 2024
18 of 19 checks passed
@wing328
Copy link
Member

wing328 commented May 21, 2024

thanks for the PR, which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants