Fix python-fastapi signature of parameters for method #18691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
May 19, 2024
| null | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
thanks for the PR.
cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)
|
@diorcety do you have a test that you could add to show the problem and how your change fixes it? |
|
An integrated test? no for the moment, but a json file yes, the one from grafana: https://github.com/grafana/grafana/blob/main/public/openapi3.json |
|
@diorcety can you please update the test spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the parameter type is an map or a list an invalid python was producted, for example:
body: = Body(None, description=""),This PR use function postProcessOperationsWithModels of AbstracPythonCodegen in order to use
vendorExtensions.x-py-typing