Add detailed tutorial for adding new evaluation benchmarks #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
reviewed
May 17, 2024
enyst
reviewed
May 17, 2024
enyst
reviewed
May 17, 2024
neubig
reviewed
May 17, 2024
There was a problem hiding this comment.
This is exciting!
One suggestions is that we can probably make the README a bit less verbose without hurting understandability at all. Personally when I see a long README I hesitate to read it a bit, so making it more concise might make it seem less intimidating.
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
Co-authored-by: Graham Neubig <neubig@gmail.com>
|
Thanks a ton, @neubig, for the feedback! I've cleaned up the README and move those comments to the actual code file :) |
li-boxuan
reviewed
May 18, 2024
li-boxuan
reviewed
May 18, 2024
|
@xingyaoww ping me when this is ready to review (maybe also considering @li-boxuan 's comments), and I'll make a final pass through! |
Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk>
Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk>
Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk>
Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk>
|
@neubig Should be ready for another round of review now :) |
neubig
approved these changes
May 18, 2024
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by OpenDevin :)