Resolved Issue 6316: Use SVG logo and icons instead of png

[JasonZelmanovich]

Fixes #6316

[wetneb]

Thank you! It does look like the logo has got a bit bigger in the process, which is perhaps fine, but intuitively when doing such a change I would try to preserve the appearance as much as possible. By introducing a visual difference, you are making your PR vulnerable to people with opinions about visual design and that's an easy way to get your contribution stuck (since tastes can vary so widely!)

Here are some before/after screenshots:

Before

After

I noticed that the SVG file you introduced has quite some margins at the top and bottom. Is that intentional? Perhaps it would be more convenient to crop those margins.

Also I have noticed there are some other uses of the PNG logo that should be converted in the same go: in project.vt for instance. You should be able to find an exhaustive list of them by searching for the filename of the PNG image.

Also I wonder if we should delete the PNG file in this PR? Or leave it for a while in case some extensions rely on its presence to include it in their own UI? No strong feelings about it.

[wetneb]

Hi @JasonZelmanovich, are you still working on this?

[JasonZelmanovich]

Yes, I plan to fix those issues by end of the day

[wetneb]

@JasonZelmanovich I have opened a broader issue about removing all uses of raster icons in the tool: #6538.
As part of that I have identified multiple copies of the OpenRefine logo, all of which would be worth deleting in this PR (I would say):

• main/webapp/modules/core/images/logo-gem-126.png
• main/webapp/modules/core/images/logo-openrefine-550.png
• extensions/gdata/src/com/google/refine/extension/gdata/logo-openrefine-550.png

Let me know if there is anything I can help you with here :)

[wetneb]

@JasonZelmanovich are you still working on this PR or should we close it?

[wetneb]

@JasonZelmanovich I'm closing this to keep our PR backlog manageable, but feel very invited to reopen a PR if you want to get back to it.