Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't always trim whitespace for TSV. Fixes #6604 #6609

Merged
merged 1 commit into from
May 27, 2024
Merged

Don't always trim whitespace for TSV. Fixes #6604 #6609

merged 1 commit into from
May 27, 2024

Conversation

tfmorris
Copy link
Member

Fixes #6604

Changes proposed in this pull request:

  • Turn off whitespace trimming for TSV parser (on by default) and use our optional trimming instead
  • Adjust test so that the TSV importer path gets tested (everything was going through the CSV importer instead)

@github-actions github-actions bot added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. import About importers in general - add a label for the data format if available CSV/TSV About the CSV/TSV import or export labels May 16, 2024
@wetneb wetneb merged commit 28d5a0c into OpenRefine:master May 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

Assignees
No one assigned
Labels
CSV/TSV About the CSV/TSV import or export import About importers in general - add a label for the data format if available Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSV import always trims white space, ignoring parse setting
2 participants
@tfmorris @wetneb