Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename library to openscap_results_parser #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

redhatrises
Copy link
Member

  • openscap_parser has a connotation that this library is performing as a SCAP validator, content scanner, and/or check engine. This PR removes that incorrect connotation. Other suggestions can be made but openscap_parser is a no-go.

- openscap_parser has a connotation that this library is performing as a SCAP validator, content scanner,
  and/or check engine. This PR removes that incorrect connotation.
Copy link
Collaborator

@akofink akofink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openscap_results_parser indicates that this gem only parses XCCDF test result files, but it also parses XCCDF datastream and tailoring files as well. I'm not sure how "openscap_parser" makes it seem like this gem does any kind of scanning/evaluation. I think the most accurate name would probably be xccdf_parser as it covers all the file types in that spec.

@redhatrises
Copy link
Member Author

openscap_results_parser indicates that this gem only parses XCCDF test result files, but it also parses XCCDF datastream and tailoring files as well. I'm not sure how "openscap_parser" makes it seem like this gem does any kind of scanning/evaluation. I think the most accurate name would probably be xccdf_parser as it covers all the file types in that spec.

I like your sugestion of xccdf_parser because this isn't really an OpenSCAP parser as it doesn't even use OpenSCAP. Will update to make that distinction.

@kbrock
Copy link

kbrock commented Jan 26, 2022

If you like this idea, probably want to merge this sooner than later.
This is begging to be a conflict magnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants