Abbreviate profile descriptions based on total profile count #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @matejak! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Merged
|
The inspection completed: 2 updated code elements |
Closed
jan-cerny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main problem with this PR:
The displayed text is set in
org_fedora_oscap/gui/spokes/oscap.py:626, but it is not HTML, so a CSS/JS trick with a clickable "More" is not applicable. The text is specified in so-called pango markup which can do nice tricks to fit a line to particular width, but it doesn't provide functionality to hide and expand long paragraphs.