fix: listener silent fail on replica #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `postgrest-with-postgresql-* --replica`, the PGRST_DB_URI will set the replica host as preference. This to be able to run quick manual tests with postgrest running on a replica.
steve-chavez
force-pushed
the
silent-replica-fail
branch
from
62b2358
to
c782030
Compare
Update hasql-notifications to include the fix on diogob/hasql-notifications#24. Which now reveals the following error: ``` $ postgrest-with-postgresql-16 --replica -f test/spec/fixtures/load.sql postgrest-run 17/May/2024:18:35:38 -0500: Successfully connected to PostgreSQL 16.2 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 13.2.0, 64-bit 17/May/2024:18:35:38 -0500: Could not listen for notifications on the "pgrst" channel. ERROR: cannot execute LISTEN during recovery 17/May/2024:18:35:38 -0500: Retrying listening for notifications... ``` This is still not good because the LISTEN channel will be retried forever without a backoff.
steve-chavez
force-pushed
the
silent-replica-fail
branch
3 times, most recently
from
b8c65cd
to
04b637c
Compare
Tried to fix that here but it's causing some test failures that only occur on CI (hard to debug). Will make the backoff in another PR to have less changes to track. Linkcheck fails Patreon permanently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update hasql-notifications to include the fix on diogob/hasql-notifications#24.
Which now reveals the following error:
This is still not good because the LISTEN channel will be retried forever (with an unnecessary schema cache reload too) without a backoff.