fix: saveSettings endpoint allowing NaN to be stored on Int settings #32428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8061ee0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32428 +/- ##
===========================================
- Coverage 56.38% 56.33% -0.05%
===========================================
Files 2434 2434
Lines 53693 53708 +15
Branches 11050 11057 +7
===========================================
- Hits 30275 30259 -16
- Misses 20779 20804 +25
- Partials 2639 2645 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
requested changes
May 27, 2024
KevLehman
requested changes
May 28, 2024
| "@rocket.chat/meteor": patch | ||
| --- | ||
|
|
||
| Stops the backend from saving invalid values for int settings (NaN for example) |
There was a problem hiding this comment.
Fixed an issue that allowed saveSettings method to save NaN values on numeric settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-418
Fixes issue that allowed empty strings to be saved in the int settings, causing an NaN value on the DB