-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rooms, teams and roles LDAP syncs are not triggered on login #32445
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 33ff139 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32445 +/- ##
===========================================
+ Coverage 55.81% 55.86% +0.05%
===========================================
Files 2413 2432 +19
Lines 53160 53476 +316
Branches 10925 10992 +67
===========================================
+ Hits 29669 29876 +207
- Misses 20871 20964 +93
- Partials 2620 2636 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
LDAP rooms, teams and roles syncs currently only work on background sync or when hitting the "Sync now" button. All of them should now be triggered on login in case the "Update User Data on Login" setting is enabled (LDAP > Data Sync)
Further comments
CORE-437