Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rooms, teams and roles LDAP syncs are not triggered on login #32445

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented May 15, 2024

Proposed changes (including videos or screenshots)

  • Fixed rooms, teams and roles LDAP syncs not running on login (even when the "Update User Data on Login" setting is enabled) due to RC being binded (authenticated) to the logged in user instead of the LDAP admin.

Issue(s)

Steps to test or reproduce

LDAP rooms, teams and roles syncs currently only work on background sync or when hitting the "Sync now" button. All of them should now be triggered on login in case the "Update User Data on Login" setting is enabled (LDAP > Data Sync)

Further comments

CORE-437

@matheusbsilva137 matheusbsilva137 added this to the 6.9 milestone May 15, 2024
Copy link
Contributor

dionisio-bot bot commented May 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 33ff139

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.86%. Comparing base (4b8c215) to head (33ff139).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32445      +/-   ##
===========================================
+ Coverage    55.81%   55.86%   +0.05%     
===========================================
  Files         2413     2432      +19     
  Lines        53160    53476     +316     
  Branches     10925    10992      +67     
===========================================
+ Hits         29669    29876     +207     
- Misses       20871    20964      +93     
- Partials      2620     2636      +16     
Flag Coverage Δ
e2e 55.22% <ø> (+0.15%) ⬆️
unit 72.72% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review May 16, 2024 13:33
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner May 16, 2024 13:33
@scuciatto scuciatto modified the milestones: 6.9, 6.10 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants