Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tracked dependencies #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dellagustin
Copy link
Contributor

Dependencies were being tracked despite the .gitignore and the postinstall script.

With this PR, the tracked dependencies are removed.
The .gitignore rules were updated to ignore everything in the lib folder except for the README.md file.

Dependencies were being tracked despite the
`.gitignore` and the postinstall script.
@spier
Copy link
Contributor

spier commented Jul 9, 2021

Great find!

Do you have any suspicions why the .gitignore file didn't work as expected? Just curious.

@dellagustin
Copy link
Contributor Author

Hi @spier, I suspect that the .gitignore rule was added after the files were already tracked (that could be verified on the history, but I did not went that far).

@Michadelic Michadelic self-requested a review July 14, 2021 09:16
Copy link
Contributor

@Michadelic Michadelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the libs are needed for the gh_pages online demo at the moment as we don't have a build step in place on this repo.

@Michadelic
Copy link
Contributor

Hi @dellagustin, these files are checked in intentionally as we do not have a build step for gh_pages currently. While they are not needed for a local setup (postinstall step is taking care of it) this would break the online demo. It could be achieved by setting up a travis job however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants