AK: Don't put element count next to heap-allocated data in FixedArray #24360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This not only makes code easier to follow but also makes it faster.
github-actions
bot
added
the
👀 pr-needs-review
|
Not that I'm in favor of one solution or the other, but that was made on purpose in this commit: |
|
Do you know why it is faster? Is it from the branch removal in |
|
Yes, because of that and because it does less indirection with size being inline. |
|
@awesomekling, do you remember where these empty |
Looking at the current uses of |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only makes code easier to follow but also makes it faster.
PS: I haven't actually tried to find FixedArray's current users in the codebase but this makes my WIP async inflate 5% faster.