Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Add database unique constraints and length changes #13079

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

FergusMok
Copy link
Contributor

@FergusMok FergusMok commented Apr 22, 2024

Part of #12048

Added some unique constraints to SQL, and increase the length of some fields as part of data migration

@FergusMok FergusMok added the s.ToReview The PR is waiting for review(s) label Apr 22, 2024
@FergusMok FergusMok self-assigned this Apr 22, 2024
Copy link

Hi @FergusMok, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@NicolasCwy
Copy link
Contributor

NicolasCwy commented Apr 23, 2024

We might need to generate a liquibase changelog for this let me check

Edit: Seems like a changelog is needed
image

@ziqing26 ziqing26 modified the milestones: V9.0.0-beta.6, V9.0.0-beta.7 Apr 23, 2024
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

should we add in the deadline extensions unique constraint as well in the PR?

@FergusMok
Copy link
Contributor Author

@cedricongjh Added the deadline extension

Awaiting confirmation about the field length, and will be adding changelog for beta 7 to the PR once confirmed

Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToReview The PR is waiting for review(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants