-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12048] Fix course migration script #13111
Open
NicolasCwy
wants to merge
31
commits into
TEAMMATES:v9-course-migration
Choose a base branch
from
NicolasCwy:fix-v9-course-migration
base: v9-course-migration
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[#12048] Fix course migration script #13111
NicolasCwy
wants to merge
31
commits into
TEAMMATES:v9-course-migration
from
NicolasCwy:fix-v9-course-migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be fixed in the main branch instead
Verify instructor migration
NicolasCwy
assigned yuanxi1, mingyuanc and NicolasCwy and unassigned NicolasCwy, yuanxi1 and mingyuanc
May 6, 2024
NicolasCwy
added
s.ToReview
The PR is waiting for review(s)
c.Task
Other non-user-facing works, e.g. refactoring, adding tests
labels
May 6, 2024
NicolasCwy
force-pushed
the
fix-v9-course-migration
branch
2 times, most recently
from
May 6, 2024 10:27
c076a8a
to
f6bb13e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c.Task
Other non-user-facing works, e.g. refactoring, adding tests
s.ToReview
The PR is waiting for review(s)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Fix course related entity seed, migration and verification. Optimisation may be needed
Credits to @marquestye for helping out with verifying and testing instructor migration