-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify selection of video stream #10730
Open
Profpatsch
wants to merge
5
commits into
TeamNewPipe:dev
Choose a base branch
from
Profpatsch:simplify-video-stream-selection
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Simplify selection of video stream #10730
Profpatsch
wants to merge
5
commits into
TeamNewPipe:dev
from
Profpatsch:simplify-video-stream-selection
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to understand the logic here, and noticed the indirection via a QualityResolver interfaces is pretty unnecessary. Just branching directly makes the logic a lot easier to follow. The `-999` sentinel value is a bit dumb, but java does not recognize that videoIndex is always initialized. Nice side-effect, the `Resolver` interface was completely unused and can be dropped.
pihug12
reviewed
Jan 6, 2024
TobiGr
added
player
Issues related to any player (main, popup and background)
codequality
Improvements to the codebase to improve the code quality
labels
Jan 6, 2024
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
The function never returns `null`.
This should make the purpose of these functions more clear.
Profpatsch
force-pushed
the
simplify-video-stream-selection
branch
from
January 6, 2024 15:49
e784673
to
71d88d0
Compare
Should I change the |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
codequality
Improvements to the codebase to improve the code quality
player
Issues related to any player (main, popup and background)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to understand the logic here, and noticed the indirection via a QualityResolver interfaces is pretty unnecessary. Just branching directly makes the logic a lot easier to follow.
The
-999
sentinel value is a bit dumb, but java does not recognize that videoIndex is always initialized.Nice side-effect, the
Resolver
interface was completely unused and can be dropped.What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence