Convert comment touch listener to a lambda #11075
Merged
+24
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fynngodau
reviewed
May 24, 2024
| @@ -128,7 +131,26 @@ public void updateFromItem(final InfoItem infoItem, | |||
| textEllipsizer.ellipsize(); | |||
|
|
|||
| //noinspection ClickableViewAccessibility | |||
| itemContentView.setOnTouchListener(CommentTextOnTouchListener.INSTANCE); | |||
| itemContentView.setOnTouchListener((v, event) -> { | |||
There was a problem hiding this comment.
I can remember times when a change just like this one would be discouraged for performance reasons because it instantiates the lambda every time that a CommentInfoItemHolder is created, and not only once. But I doubt anyone would give such advice anymore nowadays. 🙂
There was a problem hiding this comment.
The Android compiler automatically converts lambdas to singletons if possible: https://jakewharton.com/androids-java-8-support/
There was a problem hiding this comment.
@Isira-Seneviratne Ohh, that's really cool, thanks for sharing!
fynngodau
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
CommentTextOnTouchListenerclass to a lambda inCommentInfoItemHolder.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence