Typeover null values in cell edit and row edit #9739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaurya-sharma064
changed the title
|
Deployment: https://tooljet-pr-9739.onrender.com |
akshaysasidrn
changed the base branch from
release/database-1.1
to
release/database-1.1.1
akshaysasidrn
previously approved these changes
May 16, 2024
shaurya-sharma064
changed the title
akshaysasidrn
dismissed
their stale review
The merge-base changed after approval.
|
Deployment: https://tooljet-pr-9739.onrender.com |
shaurya-sharma064
added
active-review-app
create-review-app
and removed
active-review-app
labels
|
Deployment: https://tooljet-pr-9739.onrender.com |
Mekhla-Asopa
added
active-review-app
tested
and removed
suspend-review-app
needs testing
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9709
Problem:
Couldn't update the null-valued cells directly without toggling to custom or pressing backspace.
Fix:
Have created a transparent wrapper around the input when the value is null.
Clicking on it will result into null value & the div disappearing and the pointer being focused back to the input field.