Fix for foreign key breaking when column name is changed #9742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment: https://tooljet-pr-9742.onrender.com |
akshaysasidrn
changed the base branch from
release/database-1.1
to
release/database-1.1.1
akshaysasidrn
previously approved these changes
May 16, 2024
shaurya-sharma064
changed the title
akshaysasidrn
dismissed
their stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9718
Problem:
Changing the Name of the Foreign Key Column would end up breaking the foreign key relation.
Fix:
Changed the code such that the foreignKeyDetails variable gets updated when the column name gets updated too for edit column name & edit/create table features.