Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/mergeset: adds tracking for indexdb records drop #6297

Merged
merged 4 commits into from
May 24, 2024

Conversation

f41gh7
Copy link
Contributor

@f41gh7 f41gh7 commented May 17, 2024

It allows to create alert for possible item drops at indexdb. It may happen, if ingested metric size exceeds max indexdb item size.

Copy link
Contributor

@zekker6 zekker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/vmstorage/main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@hagen1778 hagen1778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f41gh7 would you mind adding an alerting rule as well?

@f41gh7 f41gh7 requested a review from hagen1778 May 20, 2024 14:47
f41gh7 and others added 4 commits May 24, 2024 11:55
It allows to create alert for possible item drops at indexdb.
It may happen, if ingested metric size exceeds max indexdb item size.
Co-authored-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>
* use `increase` instead of `rate`, because `increase` can capture increase of metric
if it was incremented before the first scrape. While `rate` will always produce 0 in this case;
* explicitly specify the look-behind window for rollup function, so it work predictable for all installations;
* rephrase the alerting rule to provide additional info to the user;
* move the alerting rule to `health` list as it is related to single and cluster installations
* typo fix

Signed-off-by: hagen1778 <roman@victoriametrics.com>
@hagen1778
Copy link
Collaborator

@f41gh7 please see my follow-up here c78adac

@hagen1778 hagen1778 merged commit 69d244e into master May 24, 2024
8 checks passed
@hagen1778 hagen1778 deleted the mergeset-new-drop-metric branch May 24, 2024 12:55
hagen1778 added a commit that referenced this pull request May 24, 2024
It allows to create alert for possible item drops at indexdb. It may
happen, if ingested metric size exceeds max indexdb item size.

---------

Signed-off-by: hagen1778 <roman@victoriametrics.com>
Co-authored-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>
Co-authored-by: hagen1778 <roman@victoriametrics.com>

(cherry picked from commit 69d244e)
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants