-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/mergeset: adds tracking for indexdb records drop #6297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekker6
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hagen1778
requested changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@f41gh7 would you mind adding an alerting rule as well?
It allows to create alert for possible item drops at indexdb. It may happen, if ingested metric size exceeds max indexdb item size.
Co-authored-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>
* use `increase` instead of `rate`, because `increase` can capture increase of metric if it was incremented before the first scrape. While `rate` will always produce 0 in this case; * explicitly specify the look-behind window for rollup function, so it work predictable for all installations; * rephrase the alerting rule to provide additional info to the user; * move the alerting rule to `health` list as it is related to single and cluster installations * typo fix Signed-off-by: hagen1778 <roman@victoriametrics.com>
hagen1778
force-pushed
the
mergeset-new-drop-metric
branch
from
May 24, 2024 12:50
905aaaf
to
c78adac
Compare
hagen1778
approved these changes
May 24, 2024
hagen1778
added a commit
that referenced
this pull request
May 24, 2024
It allows to create alert for possible item drops at indexdb. It may happen, if ingested metric size exceeds max indexdb item size. --------- Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: Zakhar Bessarab <z.bessarab@victoriametrics.com> Co-authored-by: hagen1778 <roman@victoriametrics.com> (cherry picked from commit 69d244e) Signed-off-by: hagen1778 <roman@victoriametrics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to create alert for possible item drops at indexdb. It may happen, if ingested metric size exceeds max indexdb item size.