Customize work directory #3477
Merged
Customize work directory #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergelogvinov
requested review from
mumoshu,
toast-gear,
nikola-jokic,
rentziass and
a team
as code owners
|
Hello @nikola-jokic can you take a look please... Thanks. |
sergelogvinov
force-pushed
the
workdir
branch
2 times, most recently
from
d12f7c4
to
920cf6b
Compare
nikola-jokic
added
the
gha-runner-scale-set
nikola-jokic
reviewed
Jun 4, 2024
| @@ -521,6 +521,14 @@ func (r *EphemeralRunnerReconciler) updateStatusWithRunnerConfig(ctx context.Con | |||
| jitSettings := &actions.RunnerScaleSetJitRunnerSetting{ | |||
| Name: ephemeralRunner.Name, | |||
| } | |||
|
|
|||
| for c := range ephemeralRunner.Spec.Spec.Containers { | |||
There was a problem hiding this comment.
Can you please rename c to i? c sounds like a container, while i is usually variable associated with iterations.
There was a problem hiding this comment.
Yep, thanks, fixed.
It allows us to customize the working directory during worker registration.
nikola-jokic
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is simple patch allows us to customize the working directory during gh-worker registration.
Sometimes I need to change the work directory to pull/store large files on build process.
Thanks.