Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creds_key to be passed to deeplake.empty() and deeplake.load() #2860

Merged
merged 7 commits into from
May 24, 2024

Conversation

nvoxland-al
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

As long as org_id and a token are passed along, the creds passed to deeplake.load and deeplake.empty can be given managed credentials from the organization.

Example:

ds = deeplake.empty("s3://my/path", creds={"creds_key": "aws_creds"}, org_id="my_org")
ds = deeplake.load("s3://my/path" creds={"creds_key": "aws_creds"}, org_id="my_org")

Things to be aware of

Also works with deeplake.delete and exists

Copy link

sonarcloud bot commented May 23, 2024

@nvoxland-al nvoxland-al merged commit 7ea4eed into main May 24, 2024
5 of 10 checks passed
@nvoxland-al nvoxland-al deleted the creds_key_in_deeplake_api branch May 24, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants