Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CommonJS build and add Jest setup to test app #6410

Merged
merged 4 commits into from
May 20, 2024
Merged

Fix CommonJS build and add Jest setup to test app #6410

merged 4 commits into from
May 20, 2024

Conversation

devongovett
Copy link
Member

Pulls in parcel-bundler/parcel#9722 to fix the CommonJS build. Also adds a Jest test setup to one of our example apps that renders many components to verify they work in that environment. This will run in our verdaccio CI script. I verified that the test failed using the old build and should now pass.

@rspbot
Copy link

rspbot commented May 17, 2024

@rspbot
Copy link

rspbot commented May 17, 2024

@devongovett
Copy link
Member Author

devongovett commented May 17, 2024

@rspbot
Copy link

rspbot commented May 17, 2024

@adobe adobe deleted a comment from rspbot May 17, 2024
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM did a quick sweep of the verdaccio apps, lets get this tested some more on monday

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed some weird behavior in the RAC Tailwind Example app with the popover and combobox. when you select an item in the popover, it scrolls the page up and then you have to click on the page to scroll the page again. with the combobox, there's just some weird animation when you open the combobox. otherwise, didn't notice anything weird in the other test apps

@devongovett
Copy link
Member Author

@yihuiliao could you check if these also happen on main?

@yihuiliao
Copy link
Member

@yihuiliao could you check if these also happen on main?

yep, just checked on main and seems like it also happens there so unrelated to the changes in this PR

@devongovett devongovett merged commit 8ad383b into main May 20, 2024
26 checks passed
@devongovett devongovett deleted the fix-cjs branch May 20, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants