-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨 🚨 ✨ Source Tik Tok Marketing: Migration to Low-Code #38316
Open
darynaishchenko
wants to merge
32
commits into
master
Choose a base branch
from
daryna/source-tik-tok-marketing/migartion-to-low-code
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🚨 🚨 ✨ Source Tik Tok Marketing: Migration to Low-Code #38316
darynaishchenko
wants to merge
32
commits into
master
from
daryna/source-tik-tok-marketing/migartion-to-low-code
+6,800
−4,133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
connectors/source/tiktok-marketing
labels
May 17, 2024
…pe for dimensions transformations
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
May 23, 2024
darynaishchenko
changed the title
Source Tik Tok Marketing: Migration to Low-Code
🚨 🚨 ✨ Source Tik Tok Marketing: Migration to Low-Code
May 23, 2024
artem1205
reviewed
May 31, 2024
else: | ||
stream_state = stream_states[0] | ||
kwargs = {"stream_state": stream_state, "stream_slice": stream_slice, "next_page_token": next_page_token} | ||
return [record for record in records if self._filter_interpolator.eval(self.config, record=record, **kwargs)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to align with original signature (Iterable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
artem1205
reviewed
May 31, 2024
airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/manifest.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/manifest.yaml
Outdated
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/tiktok-marketing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
resolved: https://github.com/airbytehq/airbyte-internal-issues/issues/7824
How
Migrated source to use low-code cdk instead of python cdk.
Main changes:
lifetime=true
as request param, which is deprecated on API v1.3. Now lifetime reports usequery_lifetime=true
, with this param start_date and end_date should not be provided. Exception: advertiser_lifetime_report: API v1.3 doesn't allow query_lifetime=true` with advertiser reports, so this stream was implemented exactly as in py version with start_date and end_date query params(range >=365d)Review guide
User Impact
Breaking change users will need to follow migration guide for affected streams.
Can this PR be safely reverted and rolled back?
Breaking change due to changes in schema and state format.